Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,benchmark: use tmpdir.fileURL() #49138

Merged
merged 1 commit into from
Aug 21, 2023
Merged

test,benchmark: use tmpdir.fileURL() #49138

merged 1 commit into from
Aug 21, 2023

Conversation

LiviaMedeiros
Copy link
Contributor

Refs: #49040

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Aug 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
Open
25 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Open
24 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53397/

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 17, 2023
This was referenced Aug 18, 2023
Open
Open
@LiviaMedeiros LiviaMedeiros added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit eeddbfa into nodejs:main Aug 21, 2023
43 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eeddbfa

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@LiviaMedeiros @UlisesGascon
test,benchmark: use tmpdir.fileURL()
fac56db 
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@LiviaMedeiros @targos
test,benchmark: use tmpdir.fileURL()
b011a49 
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test,benchmark: use tmpdir.fileURL()
bdcdb85 
PR-URL: nodejs/node#49138
Refs: nodejs/node#49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test,benchmark: use tmpdir.fileURL()
1eea878 
PR-URL: nodejs/node#49138
Refs: nodejs/node#49040
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LiviaMedeiros @nodejs-github-bot @lpinca